Don't mount routes to top-level context #381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't mount route helpers at top-level.
For instance, while serving an Ember application from
/admin/editor
,the application could be mounted like this:
The previous implementation allows for this, as it was written with this
use case in mind.
Alternatively, the application could be mounted from within a
namespace
,scope
, orconstraint
block. Unfortunately, the previousimplementation doesn't support these use cases, since the routes are
mounted at the global level (i.e. in the first line of a
Rails.application.routes.draw
block).This commit adds support for the latter case, taking into account the
surrounding context with which the route helpers are invoked.